-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
JIT: Fix compiler warning from visibility attribute in typedef #139981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
JIT: Fix compiler warning from visibility attribute in typedef #139981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Basically the same as my PR #140286 I've just closed since @Fidget-Spinner made me aware of yours :)
Just a suggestion:
Sorry for being such a pain, this is now merely for my understanding and I hope asking this question here is ok: When playing with the above Godbolt link, I more or less get the same nice output for
whereas on Windows x86_64 I get
which tells me, clang-cl is saving a ton more on the stack here.
|
Oh, I think I've found the answer myself: adding |
Maybe also restore the comment
that got lost in #137961? Because it is utterly important that we use |
This was introduced in #136528. The
DECLARE_TARGET
macro includesvisibility("hidden")
, which is valid for forward declarations but gets ignored when used in a typedef, so the compiler is yelling.